fix(google_ads): keep quota exhaustion out of error tracking - #89598
Conversation
Google Ads quota exhaustion (RESOURCE_EXHAUSTED) is already retried in-process with backoff. Once that budget is exhausted it re-raises and Temporal retries the whole activity, but the source had no `get_retryable_errors()` override, so the exception was still logged and reported to error tracking as if it were a bug. Add the stable "Resource has been exhausted (e.g. check quota)" message to `get_retryable_errors()`, matching the pattern already used by other ad sources (meta_ads, tiktok_ads, linkedin_ads, stripe). Generated-By: PostHog Desktop Task-Id: 70b36f4c-1152-47ea-a296-ada86ca97b3f
|
😎 Merged successfully - details. |
|
Hey @Gilbert09! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
🤖 CI report
|
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Small, contained fix by an owning-team author that reclassifies a self-recovering quota error out of error tracking; includes tests and no risky-territory surface (no API/data/auth/billing/CI changes).
- Author wrote 0% of the modified lines and has 10 merged PRs in these paths (familiarity MODERATE).
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 9L, 1F substantive, 36L/2F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1b-small (36L, 2F, single-area, fix) |
| stamphog 2.0.0b4 | .stamphog/policy.yml @ 45adf7a · reviewed head 45adf7a |
|
/trunk merge |
1 participant
Problem
A Google Ads sync that hits the account's request quota keeps getting flagged in error tracking as a bug, even though the sync recovers on its own. See error tracking issue 01a03f10-643d-7080-8a99-dd2085bfd75b.
google_ads.pyalready rides out a quota/rate-limitRESOURCE_EXHAUSTEDresponse with in-process backoff (_call_with_transient_retry). Once that budget is exhausted it re-raises, and Temporal retries the whole sync activity — butGoogleAdsSourcehad noget_retryable_errors()override, so the exception still got logged as an exception and reported as a fresh bug on every quota window that outlasts the in-process budget.Changes
GoogleAdsSource.get_retryable_errors()now matches the quota-exhausted message, so this failure is logged as a warning instead of an exception once the in-process retry budget is used up.Follows the same pattern already used by other ad sources for self-recovering failures (
meta_ads,tiktok_ads,linkedin_ads,stripe).How did you test this code?
Added
TestGoogleAdsRetryableErrors, covering:get_retryable_errors()— guards against this becoming error-tracking noise againRESOURCE_EXHAUSTEDvariant does NOT match — that one isn't retried in-process and must stay visibleRan the full
google_adssource test suite locally:340 passed. Ruff lint/format clean. Not run:mypyrepo-wide (change only adds a method matching the base class's existingset[str]signature, no new types) andhogli review(Greptile not signed in in this sandbox — did a manual self-review of the diff instead, no findings).Automatic notifications
Docs update
None — no user-facing or documented behavior changes.
🤖 Agent context
Autonomy: Fully autonomous
Investigated via PostHog error tracking (
query-error-tracking-issue,query-error-tracking-issue-events) to confirm the failure originates ingoogle_ads.py'sGoogleAdsSearchService.search, then read the source and its existing transient-retry handling. Skills invoked:/writing-tests,/writing-pr-descriptions,/reviewing-before-pr(Greptile unavailable, fell back to a manual self-review). Checked for duplicate open PRs (gh pr list --search, and every open PR by this automation) — none address this issue.Created with PostHog Desktop